chore: Add workflow for running tests/lints/format checks on CI #49
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
define-null
changed the title
define-null
changed the title
kalabukdima
reviewed
Jan 14, 2026
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: dsherret/rust-toolchain-file@v1 | ||
| - run: cargo fmt --all -- --check |
Collaborator
There was a problem hiding this comment.
The problem with formatting is that Eldar used a custom styleguide for this repo, allowing 2 empty lines between the blocks. However, the blank_lines_upper_bound option in rustfmt is still unstable. So applying the formatting at the moment will try to remove extra empty lines in all of the files
Collaborator
Author
There was a problem hiding this comment.
Do we consider unifying the style-guides on the org level or at least standardizing style-guide for the repo so that it can be enforced? Otherwise either no style guide is followed, or it becomes tedious to battle with the tools, that apply default fmt rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
PR adds workflow with jobs for running clippy, unit tests and format checks. The list of checks for clippy and default fmt rules are left as is to open the discussion rather then necessarily advocate for the particular rules or style settings.